Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lock app into portrait mode #319

Merged
merged 6 commits into from
Dec 20, 2024

Conversation

Ismaillat
Copy link
Contributor

This PR deals with issue #313

Description:

This pull request addresses the need to lock the app in portrait mode for improved user experience and to ensure consistent behavior across all screens. By restricting the orientation to portrait mode, the app avoids unintended UI issues caused by rotation.

Changes Made:

Updated the AndroidManifest.xml to set screenOrientation to portrait for all activities.
Ensured the app maintains a consistent layout regardless of device rotation.
Tested the implementation to confirm the app behavior remains stable in portrait mode.

Key Benefits:

Prevents UI glitches caused by screen rotations.
Enhances usability, especially for layouts optimized for portrait mode.
Provides a smoother and more predictable user experience.

@Ismaillat Ismaillat linked an issue Dec 19, 2024 that may be closed by this pull request
Copy link
Contributor

@mehdi-hamirifou mehdi-hamirifou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! The feature works perfectly on phones, and good job adapting the tests to ensure everything runs smoothly. This is a solid improvement to the app's usability and consistency.

Approved for merge.

@mehdi-hamirifou mehdi-hamirifou merged commit 1a7abfb into main Dec 20, 2024
3 checks passed
@rihabbelmekki rihabbelmekki deleted the feat/lock-app-into-portrait-mode branch December 20, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: lock app into portrait mode
2 participants